Uh oh!
There was an error while loading. Please reload this page.
gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings - #128726
Conversation
0788978 to
a3b61aaCompare6659cad to
6d7c395Comparee7af412 to
0f2afcdComparehugovk
commented
Jan 17, 2025
Let's merge this. @graingert Please could you update the title to reflect the current behaviour of the PR? |
graingert
commented
Jan 17, 2025
@hugovk ok, I've updated the title |
Thanks @graingert for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…test_socket which still logs warnings (pythonGH-128726) (cherry picked from commit 7807b40) Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Brett Cannon <brett@python.org>
Sorry, @graingert and @hugovk, I could not cleanly backport this to |
GH-128935 is a backport of this pull request to the 3.13 branch. |
bedevere-bot
commented
Jan 17, 2025
|
sobolevn
commented
Jan 17, 2025
I think we should revert this change and fix buildbots first. |
…ept for test_socket which still logs warnings (python#128726)" This reverts commit 7807b40.
hugovk
commented
Jan 17, 2025
Revert PR: #128936. |
bedevere-bot
commented
Jan 17, 2025
|
…cept for test_socket which still logs warnings (python#128726)" (python#128936) This reverts commit 76856ae.
…test_socket which still logs warnings (python#128726) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Brett Cannon <brett@python.org>
…ept for test_socket which still logs warnings (python#128726)" (python#128936)
Uh oh!
There was an error while loading. Please reload this page.