Uh oh!
There was an error while loading. Please reload this page.
gh-125997: improve tests for time.sleep() - #128751
Merged
Merged
Conversation
MemberAuthor
@vstinner: I plan to merge this one with the following title: and following commit message: - Add tests for durations of invalid types.
- Add tests for `int` and `float` durations.
- Add tests for (signed) zeroes and durations close to the clock resolution.Should I also add more with coverage with ns durations and for something of order 1e-16 as well? I also want to know if there's an easy way to test that a sleep has been cancelled through a signal (is there a way to exercise a Ctrl+C?) |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 13, 2025
…128751) - Add tests for durations of invalid types. - Add tests for `int` and `float` durations, including signed zeroes durations. - Add tests for nonzero very small durations and durations close to the clock resolution. --------- (cherry picked from commit b70a567) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 13, 2025
…128751) - Add tests for durations of invalid types. - Add tests for `int` and `float` durations, including signed zeroes durations. - Add tests for nonzero very small durations and durations close to the clock resolution. --------- (cherry picked from commit b70a567) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
GH-128795 is a backport of this pull request to the 3.12 branch. |
GH-128796 is a backport of this pull request to the 3.13 branch. |
picnixz
commented
Jan 13, 2025
MemberAuthor
I'm backporting the tests since the performance regression happened in 3.11 (if we fix that regression in the future, it'll be easier if the tests are already there) |
picnixz added a commit
that referenced
this pull request
Jan 13, 2025
… (#128795) gh-125997: Increase test coverage for `time.sleep()` (GH-128751) - Add tests for durations of invalid types. - Add tests for `int` and `float` durations, including signed zeroes durations. - Add tests for nonzero very small durations and durations close to the clock resolution. --------- (cherry picked from commit b70a567) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
picnixz added a commit
that referenced
this pull request
Jan 13, 2025
… (#128796) gh-125997: Increase test coverage for `time.sleep()` (GH-128751) - Add tests for durations of invalid types. - Add tests for `int` and `float` durations, including signed zeroes durations. - Add tests for nonzero very small durations and durations close to the clock resolution. --------- (cherry picked from commit b70a567) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #128274 (review).
time.sleep(0)is slower on Python 3.11 than on Python 3.10 #125997