Skip to content

gh-89745: Remove dead realpath branch in getpath.c - #128861

Closed
pelson wants to merge 1 commit into
python:mainfrom
pelson:tidy/remove-dead-code
Closed

gh-89745: Remove dead realpath branch in getpath.c#128861
pelson wants to merge 1 commit into
python:mainfrom
pelson:tidy/remove-dead-code

Conversation

@pelson

@pelsonpelson commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

The readlink code before is always taking precedence, and I don't know of a platform which has realpath but not readlink.

Note that this is a bit of a speculative change identified when tackling another getpath[.py] issue - I have no broad knowledge of platforms to be 100% certain that realpath without readlink isn't a thing.

@pelson

Copy link
Copy Markdown
ContributorAuthor

@pelson

Copy link
Copy Markdown
ContributorAuthor

@FFY00 and @zooba - is this a worthwhile change? If so, I'm happy to open up an issue, rebase, etc.

If not, I would also be happy to just close the PR.

@picnixzpicnixz changed the title gh-XXXXX: Remove dead realpath branch in getpath.cgh-89745: Remove dead realpath branch in getpath.cJan 21, 2025
@picnixz

This comment was marked as resolved.

@picnixzpicnixz mentioned this pull request Jan 21, 2025
@zooba

Copy link
Copy Markdown
Member

I have no broad knowledge of platforms to be 100% certain that realpath without readlink isn't a thing.

Me neither. I'm not confident to remove code that I copy-pasted (I assume from posixmodule.c, possibly from fileutils.c, but I expect if it were there then I could've just called it).

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 21, 2026
@picnixz

Copy link
Copy Markdown
Member

Closing as we are not entirely sure it is really a dead path.

@picnixzpicnixz closed this Apr 21, 2026
@pelson
pelson deleted the tidy/remove-dead-code branch April 21, 2026 07:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewskip issueskip newsstaleStale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pelson@picnixz@zooba@ZeroIntensity