Uh oh!
There was an error while loading. Please reload this page.
gh-71339: Use new assertion methods in tests - #129046
Conversation
picnixz
commented
Jan 20, 2025
Not sure if it's me or not, but having that many files to review makes my GH interface crash (or load very slowly). Would it be possible to split this PR, at least per folders? just so that 1) it reduces the number of review requests 2) it helps us to review if possible? |
serhiy-storchaka
commented
Jan 20, 2025
I have already already created 15 other PRs for groups of files with significant number of changes. But it is not worth to create a PR for 5 changed lines in 2 files. |
I non-recursively searched This is the 1 AMD64 Android failure. |
serhiy-storchaka
commented
Jan 23, 2025
The patch was initially created in 2016. It was then updated few years later, and just before creating this PR. Since the IDLE tests are located outside of the |
mhsmith
commented
Jan 23, 2025
!buildbot ios |
bedevere-bot
commented
Jan 23, 2025
mhsmith
commented
Jan 23, 2025
!buildbot android |
bedevere-bot
commented
Jan 23, 2025
mhsmith
commented
Jan 23, 2025
!buildbot android |
bedevere-bot
commented
Jan 23, 2025
mhsmith
commented
Jan 23, 2025
Not sure what happened before with Android and iOS, but they both seem fine now. |
serhiy-storchaka
commented
Jan 24, 2025
It was an issue in different tests which was fixed by #129133. No need to trigger buildbots. This PR is not emergent. It will be merged after merging all related PRs. Some changes can be extracted into separate PRs (like IDLE's). |
serhiy-storchaka
commented
May 22, 2025
There have been practically no conflicts in the last few months. This means that this PR affects a very small part of the code that is actively changing. So I plan to merge this PR without backporting to 3.13. Probability of conflicts in future backports to 3.13 is low. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit 2602d8a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-134498 is a backport of this pull request to the 3.14 branch. |
They provide better error report.
Only 1-2 lines are changed in the half of files, 3-4 lines in other quarter of files, and only in about 10 files there are more than 10 changed lines. So all this have been united in a single PR.