Uh oh!
There was an error while loading. Please reload this page.
gh-129173: Use _PyUnicodeError_GetParams in PyCodec_IgnoreErrors - #129174
Merged
picnixz merged 8 commits intoJan 24, 2025
Merged
Conversation
picnixz
marked this pull request as ready for review
January 23, 2025 15:07
vstinner
approved these changes
Jan 23, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
picnixz
deleted the
feat/codecs/simple-handlers-refactorization-129173
branch
January 24, 2025 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a draft as it depends on completion of #126004.This also cleans up the strict handler which has no issue per se but I'd like to make it consistent with other handlers.
_PyUnicodeError_GetParamsand extract complex logic into separate functions #129173