Skip to content

gh-129223: Raise KeyError in search_map_for_section() if not found - #129262

Merged
ambv merged 2 commits into
python:mainfrom
vstinner:search_map_for_section
Jan 25, 2025
Merged

gh-129223: Raise KeyError in search_map_for_section() if not found#129262
ambv merged 2 commits into
python:mainfrom
vstinner:search_map_for_section

Conversation

@vstinner

@vstinnervstinner commented Jan 24, 2025

Copy link
Copy Markdown
Member

@vstinner
vstinnerforce-pushed the search_map_for_section branch from 266eeee to c8c5241CompareJanuary 24, 2025 13:49
@vstinner

Copy link
Copy Markdown
MemberAuthor

@pablogsal@ambv@encukou: This change fix the SystemError in test_external_inspection on Fedora Stable with LTO.

@ambv

ambv commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

I'm not crazy about this approach because silently skipping tests when we couldn't find a section on a platform that we expected to be able to find the section is a bug. The fix in #129225 actually addresses the problem, which was the compiler optimizing away debug sections unless __attribute__((used)) was used.

@vstinner

Copy link
Copy Markdown
MemberAuthor

I can modify my PR to not skip the tests on KeyError.

@pablogsal

Copy link
Copy Markdown
Member

I can modify my PR to not skip the tests on KeyError.

This should be fixed by the real fix #129225. Please, let's remove the skips because that will be masking actual errors that we want to fix. Let's merge the PR with the new raising of KeyError 👍

@vstinner

Copy link
Copy Markdown
MemberAuthor

@ambv@pablogsal: Ok, I modified my PR only to fix the SystemError, tests are no longer skipped.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@ambv@pablogsal