Uh oh!
There was an error while loading. Please reload this page.
gh-129223: Raise KeyError in search_map_for_section() if not found - #129262
Conversation
266eeee to
c8c5241Comparevstinner
commented
Jan 24, 2025
@pablogsal@ambv@encukou: This change fix the SystemError in test_external_inspection on Fedora Stable with LTO. |
ambv
commented
Jan 24, 2025
I'm not crazy about this approach because silently skipping tests when we couldn't find a section on a platform that we expected to be able to find the section is a bug. The fix in #129225 actually addresses the problem, which was the compiler optimizing away debug sections unless |
vstinner
commented
Jan 24, 2025
I can modify my PR to not skip the tests on KeyError. |
pablogsal
commented
Jan 25, 2025
This should be fixed by the real fix #129225. Please, let's remove the skips because that will be masking actual errors that we want to fix. Let's merge the PR with the new raising of KeyError 👍 |
vstinner
commented
Jan 25, 2025
@ambv@pablogsal: Ok, I modified my PR only to fix the |
Uh oh!
There was an error while loading. Please reload this page.