Uh oh!
There was an error while loading. Please reload this page.
gh-127146: Update test skips for Emscripten 4.0.1 - #129375
Conversation
9c27f1f to
e2a80f3Compare
freakboy3742
left a comment
There was a problem hiding this comment.
All makes sense; the only issue preventing merge is the RTD build failure... not sure what is going on there. I'll poke around and see what I can find out.
zware
commented
Jan 28, 2025
Dumb question, but can the Emscripten version be detected so as to skip based on that version? I think there's prior art for this for various other platforms. |
freakboy3742
commented
Jan 28, 2025
It almost certainly can be; but it will require the analog of |
hoodmane
commented
Jan 28, 2025
We have defis_emscripten_lt(ver):
ifnotis_emscripten:
returnFalsever_tuple=tuple(int(x) forxinver.split("."))
returnsys._emscripten_info.emscripten_version<ver_tupleand then put |
freakboy3742
commented
Jan 28, 2025
We'll eventually want to surface the version in platform for consistency, rather than the semi-private name on We could also consider making this a feature of |
PR emscripten-core/emscripten#23306 fixed stating pipes and will be released as part of Emscripten 4.0.2. I removed skips for various other testes that were fixed in 4.0.1 or earlier.