Skip to content

gh-128690: Use test_embed in PGO profile builds again - #129377

Closed
neonene wants to merge 1 commit into
python:mainfrom
neonene:restore_embed
Closed

gh-128690: Use test_embed in PGO profile builds again#129377
neonene wants to merge 1 commit into
python:mainfrom
neonene:restore_embed

Conversation

@neonene

@neoneneneonene commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

This reverts the temporal commit b00e125.

The issue with test_init_pyvenv_cfg failing is closed as resolved.

cc @ned-deily

@vstinner

Copy link
Copy Markdown
Member

test_embed is slow and mostly spawns sub-processes. I'm not convinced that it's an useful tests to train the PGO build.

cc @pablogsal@corona10@markshannon

@neonene

Copy link
Copy Markdown
ContributorAuthor

I'd prefer a more explicit announcement if test_embed will not be used in PGO. Also, I'd prefer older versions (3.10 to 3.13) to have the same conditions.

@vstinner

Copy link
Copy Markdown
Member

I'd prefer a more explicit announcement if test_embed will not be used in PGO. Also, I'd prefer older versions (3.10 to 3.13) to have the same conditions.

I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category.

@neonene

neonene commented Feb 4, 2025

Copy link
Copy Markdown
ContributorAuthor

I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category.

I have opened #129660.

@neoneneneonene closed this Feb 4, 2025
@neonene
neonene deleted the restore_embed branch February 5, 2025 15:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@neonene@vstinner