Uh oh!
There was an error while loading. Please reload this page.
GH-127432: add cross-build-linux as a required CI job - #129459
Merged
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
AA-Turner
commented
Jan 30, 2025
Member
Is there risk of flakiness from this job? It may be worth evaluating it for a few days to get a baseline, before requiring it for merge. |
FFY00
commented
Jan 30, 2025
MemberAuthor
There shouldn't be, we only run a subset of tests, which exercise most of the code that is relevant on cross builds. We can wait a couple days to evaluate it, though I don't currently have the bandwidth to keep an eye on other PRs to gauge it. |
FFY00
commented
Feb 8, 2025
MemberAuthor
We've waited a little bit, did anyone notice unexpected failures on this job in the meantime? |
hugovk
approved these changes
Feb 12, 2025
hugovk
left a comment
Member
There was a problem hiding this comment.
I've not seen any issues with this one, I think we're good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @hugovk