bpo-36461: Added the total_time parameter to the timeit.autorange() function. by mangrisano · Pull Request #12953 · python/cpython

mangrisano · 2019-04-25T19:55:22Z

Add target_time parameter in the init.
Add some tests to test when repeat is 1 or more.

https://bugs.python.org/issue36461

the-knights-who-say-ni · 2019-04-25T19:55:25Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

ezio-melotti

I left a couple of comments about the tests.

bedevere-bot · 2019-04-25T20:38:20Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

mangrisano · 2019-04-25T21:54:30Z

I've just made the requested changes. Please review.

tirkarthi · 2019-04-26T04:53:52Z

There is also another PR that seems to add some additional changes along with the autorange changes in this PR : #12954

mangrisano · 2019-04-26T07:38:31Z

I've just read that there's another PR for this issue and it seems to be more complete than mine. What am I suppose to do in this case?

eamanu

Hello, like say @tirkarthi this PR is related to #12954
and seems more complete that this.

But, this PR is older (one PR older) and receive more feedback.

* Rename the argument from total_time to target_time after Steven's review. * Add some tests to test when number of repeat is 1 or more. * Add target_time parameter in the __init__.

mangrisano · 2019-06-02T12:38:40Z

I have made the requested changes; please review again.

bedevere-bot · 2019-06-02T12:38:42Z

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

bedevere-bot · 2019-06-03T00:12:56Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

* Delete duplicate test. * Fix indentation.

mangrisano · 2019-06-03T11:41:45Z

I have made the requested changes; please review again.

bedevere-bot · 2019-06-03T11:41:49Z

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

mangrisano · 2019-06-03T13:13:08Z

I'm trying to figure out how to write a good test for testing the autorange with callback and target_time.

* Add the test for autorange with callback. * Add the test for autorange with callback and target_time.

mangrisano · 2019-06-03T20:07:21Z

I have made the requested changes; please review again.

bedevere-bot · 2019-06-03T20:07:23Z

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

mangrisano · 2019-06-27T10:12:23Z

@stevendaprano Could you review this pull request when you're ready? Thank you :)

the-knights-who-say-ni added the CLA not signed label Apr 25, 2019

bedevere-bot added the awaiting review label Apr 25, 2019

ezio-melotti requested changes Apr 25, 2019
View reviewed changes

Comment threadLib/test/test_timeit.py Outdated
Comment threadLib/test/test_timeit.py Outdated
Comment threadLib/test/test_timeit.py Outdated

bedevere-bot added awaiting changes and removed awaiting review labels Apr 25, 2019

tirkarthi reviewed Apr 26, 2019
View reviewed changes

Comment threadLib/test/test_timeit.py Outdated

tirkarthi reviewed Apr 26, 2019
View reviewed changes

Comment threadLib/test/test_timeit.py Outdated
Comment threadLib/test/test_timeit.py Outdated
Comment threadDoc/library/timeit.rst Outdated

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Apr 26, 2019

eamanu reviewed Apr 27, 2019
View reviewed changes

mangrisano added 6 commits May 16, 2019 22:54

Add the total_time argument to the timeit.autorange() function
4be2fdf

Address review comments and improve the tests
c292a30

bpo-36461: Improve the code after review comments
747847c

bpo-36461: Address review comments and improve the code.
d0f6266
* Rename the argument from total_time to target_time after Steven's review. * Add some tests to test when number of repeat is 1 or more. * Add target_time parameter in the __init__.

Change the default value of target_time parameter
f282a0b

Fix versionchanged format
4459300

bedevere-bot removed the awaiting changes label Jun 2, 2019

bedevere-bot added the awaiting change review label Jun 2, 2019

ezio-melotti requested changes Jun 3, 2019
View reviewed changes

Comment threadLib/test/test_timeit.py Outdated
Comment threadLib/test/test_timeit.py Outdated
Comment threadLib/test/test_timeit.py Outdated
Comment threadLib/test/test_timeit.py
Comment threadLib/timeit.py Outdated
Comment threadLib/timeit.py Outdated

bedevere-bot added awaiting changes and removed awaiting change review labels Jun 3, 2019

bpo-36461: Address review comments
7440a8b
* Delete duplicate test. * Fix indentation.

bedevere-bot added awaiting change review and removed awaiting changes labels Jun 3, 2019

bpo-36461: Add a test for autorange.
ce68e95
* Add the test for autorange with callback. * Add the test for autorange with callback and target_time.

ezio-melotti removed the CLA signed label Jul 13, 2022

csabella mentioned this pull request Aug 13, 2023
timeit: Additional changes for autorange #80642
Closed

mangrisano closed this by deleting the head repository Aug 21, 2025

Uh oh!

Uh oh!

Conversation

mangrisano commented Apr 25, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Apr 25, 2019

Uh oh!

ezio-melotti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 25, 2019

Uh oh!

mangrisano commented Apr 25, 2019

Uh oh!

tirkarthi commented Apr 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mangrisano commented Apr 26, 2019

Uh oh!

eamanu left a comment

Choose a reason for hiding this comment

Uh oh!

mangrisano commented Jun 2, 2019

Uh oh!

bedevere-bot commented Jun 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jun 3, 2019

Uh oh!

mangrisano commented Jun 3, 2019

Uh oh!

bedevere-bot commented Jun 3, 2019

Uh oh!

mangrisano commented Jun 3, 2019

Uh oh!

mangrisano commented Jun 3, 2019

Uh oh!

bedevere-bot commented Jun 3, 2019

Uh oh!

mangrisano commented Jun 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mangrisano commented Apr 25, 2019•
edited
Loading