Uh oh!
There was an error while loading. Please reload this page.
Emscripten: use better _Py_Version computation for worker module - #129757
Merged
freakboy3742 merged 1 commit intoFeb 7, 2025
Merged
Conversation
agriyakhetarpal
requested review from
brettcannon and freakboy3742
as code ownersFebruary 6, 2025 23:46
All commit authors signed the Contributor License Agreement. |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
agriyakhetarpal
commented
Feb 6, 2025
ContributorAuthor
This is my first PR to CPython, and I have signed the CLA. The |
_Py_Version computation for worker module_Py_Version computation for worker modulefreakboy3742
approved these changes
Feb 7, 2025
freakboy3742
left a comment
Contributor
There was a problem hiding this comment.
Agreed - that is a lot more elegant! Thanks for the patch!
bedevere-bot
commented
Feb 7, 2025
|
agriyakhetarpal
deleted the
fix/better-py-version-check-for-emscripten-build
branch
February 7, 2025 07:15
srinivasreddy pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
…ython#129757) Use integer bit shifting instead of conversion to strings to compute Python version.
freakboy3742
commented
Feb 7, 2025
Contributor
Buildbot failure is unrelated to this change; it looms like a network connectivity issue on the host machine. |
cmaloney pushed a commit
to cmaloney/cpython
that referenced
this pull request
Feb 8, 2025
…ython#129757) Use integer bit shifting instead of conversion to strings to compute Python version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to gh-127113
This is a small PR that improves the _Py_Version check for the Python worker module file for the Emscripten builds, which was last modified in https://github.com/python/cpython/pull/127113/files#diff-31f61a127a59386957acba86e9acedf0a96bc6ebe1ac159a48e39b1a291111b5R73-R75. I reviewed the corresponding change downstream in pyodide/pyodide#5406 and suggested this change, and @hoodmane suggested that I should upstream the change here.
The idea is that we were converting a number to a hex string, then padding that string, splitting it up, and then bringing it back by parsing it to an integer – these operations are unnecessary. We can instead use an unsigned right shift and apply a bitmask to grab the relevant bytes. For the format
0xMMmmpp00, this means that the major version is in bits 24–31, the minor version in bits 16–23, and the patch/micro version in bits 8–15. These bit operations should be more direct.