Uh oh!
There was an error while loading. Please reload this page.
gh-111178: fix UBSan failures in Modules/_lzmamodule.c - #129783
Merged
Conversation
picnixz
commented
Feb 7, 2025
MemberAuthor
Ah I'm sorry I put this one as ready for review but I learned that _ + capital letter was also UB (#128248 (comment)) so I'll fix them tomorrow. |
picnixz
marked this pull request as draft
February 7, 2025 18:33
picnixz
marked this pull request as ready for review
February 8, 2025 09:27
encukou
reviewed
Feb 17, 2025
| } | ||
| PyTypeObject *tp = Py_TYPE(self); | ||
| tp->tp_free((PyObject *)self); | ||
| tp->tp_free(self); |
MemberAuthor
There was a problem hiding this comment.
tp_free takes a void * as input, so it doesn't matter. I've chosen the one that reduces the diff (but honestly, I don't know whether I've always been consistent)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.