Skip to content

gh-111178: fix UBSan failures in Objects/typeobject.c - #129799

Merged
picnixz merged 7 commits into
python:mainfrom
picnixz:fix/ubsan/typeobject-111178
Feb 25, 2025
Merged

gh-111178: fix UBSan failures in Objects/typeobject.c#129799
picnixz merged 7 commits into
python:mainfrom
picnixz:fix/ubsan/typeobject-111178

Conversation

@picnixz

@picnixzpicnixz commented Feb 7, 2025

Copy link
Copy Markdown
Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

Comment threadObjects/typeobject.c Outdated
Comment threadObjects/typeobject.c
Comment threadObjects/typeobject.c Outdated
@picnixz
picnixz marked this pull request as draft February 21, 2025 15:50
@picnixz
picnixz marked this pull request as ready for review February 22, 2025 10:15
Comment threadObjects/typeobject.c Outdated

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz
picnixz enabled auto-merge (squash) February 25, 2025 10:23
@picnixz
picnixz merged commit 3d40317 into python:mainFeb 25, 2025
@picnixz
picnixz deleted the fix/ubsan/typeobject-111178 branch February 25, 2025 10:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@vstinner