Skip to content

bpo-21536: On Android, C extensions are linked to libpython - #12989

Merged
vstinner merged 2 commits into
python:masterfrom
xdegaye:bpo-21536
Apr 29, 2019
Merged

bpo-21536: On Android, C extensions are linked to libpython#12989
vstinner merged 2 commits into
python:masterfrom
xdegaye:bpo-21536

Conversation

@xdegaye

@xdegayexdegaye commented Apr 27, 2019•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@vstinner
vstinner merged commit 254b309 into python:masterApr 29, 2019
@vstinner

vstinner commented Apr 29, 2019

Copy link
Copy Markdown
Member

LGTM. Thanks @xdegaye for this fix!

I tested the PR on Linux: C extensions are still not linked to libpython, as expected.

Xavier tested the cross-compilation to Android.

@embray

embray commented May 24, 2019

Copy link
Copy Markdown
Contributor

Note: This is a follow-up to #12946.

embray
embray reviewed May 24, 2019
View reviewed changes
Comment threadconfigure.ac

# On Android the shared libraries must be linked with libpython.
AC_SUBST(LIBPYTHON)
if test -z "$ANDROID_API_LEVEL"; then

@embrayembrayMay 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, being that I'm unfamiliar with build issues on Android why the specific test for $ANDROID_API_LEVEL and not something more generic like:

case $host in
*-linux-android*) ....

?

Reason being, I need to add additional cases where libpython should be linked explicitly (e.g. Cygwin, MinGW, etc.) and it would be easier to build off the host_os for this than something very Android-specific.

@xdegayexdegayeMay 24, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a test based on $ANDROID_API_LEVEL or on $host as you suggest is equivalent.

@xdegaye
xdegaye deleted the bpo-21536 branch December 10, 2019 12:20
@pitroupitrou mentioned this pull request Sep 2, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@embrayembrayembray left review comments
@auvipyauvipyauvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xdegaye@vstinner@embray@auvipy@the-knights-who-say-ni@bedevere-bot