Skip to content

gh-129173: refactor PyCodec_ReplaceErrors into separate functions - #129893

Merged
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/codecs/replace-handler-129173
Feb 25, 2025
Merged

gh-129173: refactor PyCodec_ReplaceErrors into separate functions#129893
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/codecs/replace-handler-129173

Conversation

@picnixz

@picnixzpicnixz commented Feb 9, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

We also refactor that handler and extract the logic for each exceptions being handled into separate functions.

@picnixz
Use new helpers in the replace handler.
eb2237a
We also refactor that handler and extract the logic for each
exceptions being handled into separate functions.
@bedevere-appbedevere-appBot mentioned this pull request Feb 9, 2025
Closed
@picnixz
picnixz marked this pull request as ready for review February 23, 2025 10:19
@picnixz
picnixz requested a review from encukouFebruary 23, 2025 10:19
encukou
encukou reviewed Feb 24, 2025
View reviewed changes
Comment threadPython/codecs.c Outdated
@AA-TurnerAA-Turner changed the title gh-129173: Use new helpers in the replace handler.gh-129173: Use new helpers in the replace handlerFeb 24, 2025
encukou
encukou reviewed Feb 24, 2025
View reviewed changes
Comment threadPython/codecs.c Outdated
encukou
encukou approved these changes Feb 25, 2025
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Comment threadPython/codecs.c
@picnixz
picnixz merged commit fa6a814 into python:mainFeb 25, 2025
@picnixz
picnixz deleted the feat/codecs/replace-handler-129173 branch February 25, 2025 13:24
@picnixzpicnixz changed the title gh-129173: Use new helpers in the replace handlergh-129173: refactor PyCodec_ReplaceErrors into separate functionsMar 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@encukou