Uh oh!
There was an error while loading. Please reload this page.
gh-130312: SET_ADD should not lock - #130136
Merged
Merged
Conversation
DinoV
marked this pull request as ready for review
February 19, 2025 18:08
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
colesbury
approved these changes
Mar 4, 2025
colesbury
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
One minor formatting comment below
Comment on lines
+967
to
+980
| int err = _PySet_AddTakeRef((PySetObject *)PyStackRef_AsPyObjectBorrow(set), | ||
| PyStackRef_AsPyObjectSteal(v)); |
Contributor
There was a problem hiding this comment.
Suggested change
| interr=_PySet_AddTakeRef((PySetObject*)PyStackRef_AsPyObjectBorrow(set), | |
| PyStackRef_AsPyObjectSteal(v)); | |
| interr=_PySet_AddTakeRef((PySetObject*)PyStackRef_AsPyObjectBorrow(set), | |
| PyStackRef_AsPyObjectSteal(v)); |
mpage
commented
Mar 17, 2025
Contributor
@DinoV - Can this be merged? |
DinoVforce-pushed
the
set_add_nolock
branch
5 times, most recently
from
March 20, 2025 16:36
557ee19 to
73fac71Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation.
https://github.com/facebookexperimental/free-threading-benchmarking/tree/main/results/bm-20250214-3.14.0a5+-247f5bf-NOGIL