Skip to content

gh-128627: Skip wasm-gc on iOS Safari where it's broken - #130418

Merged
freakboy3742 merged 3 commits into
python:mainfrom
ambv:skip-wasm-gc-ios
Feb 23, 2025
Merged

gh-128627: Skip wasm-gc on iOS Safari where it's broken#130418
freakboy3742 merged 3 commits into
python:mainfrom
ambv:skip-wasm-gc-ios

Conversation

@ambv

@ambvambv commented Feb 21, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Downstream pyodide issue: pyodide/pyodide#5428.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

@ambv
pythongh-128627: Skip wasm-gc on iOS Safari where it's broken
0da9a0c
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.
Downstream pyodide issue: pyodide/pyodide#5428.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
@bedevere-appbedevere-appBot mentioned this pull request Feb 21, 2025
Closed
ambv added a commit to ambv/pyodide that referenced this pull request Feb 21, 2025
@ambv
Skip wasm-gc on iOS Safari where it's borked
6324ebd
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.
Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
@ambvambv mentioned this pull request Feb 21, 2025
Merged
ambv added a commit to ambv/pyodide that referenced this pull request Feb 21, 2025
@ambv
Skip wasm-gc on iOS Safari where it's borked
3432a3b
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.
Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
@hoodmane

hoodmane commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

Thanks @ambv!

hoodmane
hoodmane reviewed Feb 21, 2025
View reviewed changes
Comment threadPython/emscripten_trampoline.c Outdated
freakboy3742
freakboy3742 reviewed Feb 22, 2025
View reviewed changes
Comment threadPython/emscripten_trampoline.c Outdated
@ambv@hoodmane
Don't use navigator if it doesn't exist (hi, Node)
2d706e6
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
freakboy3742
freakboy3742 approved these changes Feb 23, 2025
View reviewed changes

@freakboy3742freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the fix!

@freakboy3742
freakboy3742 merged commit 72ea3c0 into python:mainFeb 23, 2025
hoodmane pushed a commit to pyodide/pyodide that referenced this pull request Feb 24, 2025
@ambv
Skip wasm-gc on iOS Safari where it's borked (#5445)
fb4d18d
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolves#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 24, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
aeb2b80
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
5dc2f76
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
ecdb784
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
0b8c748
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
4e0e330
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
1821662
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
1330862
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
5a4da64
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
c63b455
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
4010396
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
ac22880
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
1036f6f
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 26, 2025
@ambv@hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
b6865f9
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolvespyodide#5428.
@ambv
ambv deleted the skip-wasm-gc-ios branch May 5, 2025 21:10
@ryanking13ryanking13 mentioned this pull request Jun 11, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoodmanehoodmanehoodmane approved these changes
@freakboy3742freakboy3742freakboy3742 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ambv@hoodmane@freakboy3742