Skip to content

gh-130419: Do not build the _freeze_module twice in case of Windows PGO builds - #130420

Merged
zooba merged 1 commit into
python:mainfrom
chris-eibl:skip_freeze_pgupdate
Feb 24, 2025
Merged

gh-130419: Do not build the _freeze_module twice in case of Windows PGO builds#130420
zooba merged 1 commit into
python:mainfrom
chris-eibl:skip_freeze_pgupdate

Conversation

@chris-eibl

@chris-eiblchris-eibl commented Feb 21, 2025

Copy link
Copy Markdown
Member

Make the Windows PGO build slightly faster by not building the _freeze_module again in the PGUpdate phase.

I think this is a skip-news?

This will also speed up clang-cl PGO build time (#130090).

Using the same idea, all projects with SupportPGO=False could be built only once (mostly _test modules), but I think this is not worth the effort.

in case of Windows PGO builds
@chris-eibl

Copy link
Copy Markdown
MemberAuthor

@zooba I think this is an easy one?

@zooba

Copy link
Copy Markdown
Member

Should be easy, yes, but I'm running a test release to be sure.

@chris-eibl

Copy link
Copy Markdown
MemberAuthor

Yeah, always good to double check :)

@zooba

Copy link
Copy Markdown
Member

My extra test was good, so this is okay to merge. GitHub appears to be unhappy about something today though, so my merge isn't going through. If someone else manages to get it to merge, then go ahead!

@zooba
zooba merged commit 3a555f0 into python:mainFeb 24, 2025
@chris-eibl
chris-eibl deleted the skip_freeze_pgupdate branch February 25, 2025 15:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-eibl@zooba@tomasr8