Uh oh!
There was an error while loading. Please reload this page.
[3.13] GH-121970: Extract pydoc_topics into a new extension (#129116) - #130441
Conversation
…pythonGH-129116) (cherry picked from commit 01bcf13) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
pydoc_topics into a new extension (#129116)pydoc_topics into a new extension (#129116)# Conflicts: # Doc/tools/extensions/pyspecific.py
hugovk
commented
Feb 22, 2025
Will this also introduce the lint failure during the next release? |
AA-Turner
commented
Feb 22, 2025
I still haven't managed to reproduce the error (note this PR is fine). Local tests with the offending doctest line also seem fine. |
hugovk
commented
Feb 22, 2025
I can reproduce on cd Doc
make clean venv pydoc-topics
cp build/pydoc-topics/topics.py ../Lib/pydoc_data/topics.pyIt adds a trailing space on line 5617. The release process does this, but the regular CI doesn't, so PRs will pass. |
This is very odd. I thought it might be my IDE stripping line endings, so I ran the following from a powershell terminal with my IDE closed: A few changes, but nothing on 5617... I will attempt to try via WSL... Edit: Same result via WSL... $ cd Doc
$ make clean venv pydoc-topics
$ cp build/pydoc-topics/topics.py ../Lib/pydoc_data/topics.py
$ git commit -am tmp |
AA-Turner
commented
Feb 26, 2025
#130492 has now been merged, I'll apply the backport labels to it when these PRs are merged. |
(cherry picked from commit 01bcf13)
pyspecific#121970📚 Documentation preview 📚: https://cpython-previews--130441.org.readthedocs.build/