Skip to content

gh-130461: Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst - #130526

Merged
hugovk merged 3 commits into
python:mainfrom
Mr-Sunglasses:remove-index-from-uuid
Feb 25, 2025
Merged

gh-130461: Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst#130526
hugovk merged 3 commits into
python:mainfrom
Mr-Sunglasses:remove-index-from-uuid

Conversation

@Mr-Sunglasses

@Mr-SunglassesMr-Sunglasses commented Feb 24, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir awaiting review labels Feb 24, 2025
@bedevere-appbedevere-appBot mentioned this pull request Feb 24, 2025
Closed
@Mr-Sunglasses

Mr-Sunglasses commented Feb 24, 2025

Copy link
Copy Markdown
ContributorAuthor

@picnixz , I've done the changes, Please Review it.

picnixz
picnixz reviewed Feb 24, 2025
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2025-02-25-03-53-00.gh-issue-130461.asr2dg.rst Outdated
@Mr-Sunglasses@picnixz
chore: Update Misc/NEWS.d/next/Library/2025-02-25-03-53-00.gh-issue-1…
a4e30c5
…30461.asr2dg.rst
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixzpicnixz mentioned this pull request Feb 24, 2025
Closed
hugovk
hugovk approved these changes Feb 25, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

picnixz added a commit to picnixz/cpython that referenced this pull request Feb 25, 2025
@picnixz
remove.. index::directive in prevision ofpythongh-130526
70872bf
@hugovk
hugovk merged commit 85f1cc8 into python:mainFeb 25, 2025
@hugovkhugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 25, 2025
@miss-islington-app

miss-islington-appBot commented Feb 25, 2025

Copy link
Copy Markdown

Thanks @Mr-Sunglasses for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Feb 25, 2025

Copy link
Copy Markdown

Thanks @Mr-Sunglasses for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Feb 25, 2025

Copy link
Copy Markdown

Sorry, @Mr-Sunglasses and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 85f1cc8d60b06d5b2af3e4da8e4f98171420dd91 3.12

@miss-islington-app

miss-islington-appBot commented Feb 25, 2025

Copy link
Copy Markdown

Sorry, @Mr-Sunglasses and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 85f1cc8d60b06d5b2af3e4da8e4f98171420dd91 3.13

@picnixz

picnixz commented Feb 25, 2025

Copy link
Copy Markdown
Member

The conflicts are because uuid8 doesn't exist in 3.12/3.13 I think

@hugovk

hugovk commented Feb 25, 2025

Copy link
Copy Markdown
Member

@Mr-Sunglasses Please could you do the backports?

@Mr-Sunglasses

Mr-Sunglasses commented Feb 25, 2025

Copy link
Copy Markdown
ContributorAuthor

@Mr-Sunglasses Please could you do the backports?

Sure I'll do it :-)

@hugovkhugovk mentioned this pull request Feb 25, 2025
Merged
@Mr-SunglassesMr-Sunglasses mentioned this pull request Feb 25, 2025
Merged
@bedevere-app

bedevere-appBot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130546 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Feb 25, 2025
@Mr-SunglassesMr-Sunglasses mentioned this pull request Feb 25, 2025
Merged
Mr-Sunglasses added a commit to Mr-Sunglasses/cpython that referenced this pull request Feb 25, 2025
@Mr-Sunglasses@picnixz
pythongh-130461: Remove unnecessary usages of.. index::directives…
dc6d1e3
… in Doc/library/uuid.rst (python#130526)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
(cherry picked from commit 85f1cc8)
@bedevere-app

bedevere-appBot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130548 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Feb 25, 2025
@bedevere-app

bedevere-appBot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130546 is a backport of this pull request to the 3.12 branch.

@bedevere-app

bedevere-appBot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130548 is a backport of this pull request to the 3.13 branch.

hugovk pushed a commit that referenced this pull request Feb 25, 2025
@Mr-Sunglasses@picnixz
[3.13]gh-130461: Remove unnecessary usages of.. index::directive…
28bfc1c
…s in Doc/library/uuid.rst (#130526) (#130548)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
hugovk added a commit that referenced this pull request Feb 25, 2025
@Mr-Sunglasses@picnixz@hugovk
[3.12]gh-130461: Remove unnecessary usages of.. index::directive…
ca9e52d
…s in Doc/library/uuid.rst (#130526) (#130546)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@picnixzpicnixzpicnixz approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

Assignees

@hugovkhugovk

Labels

docsDocumentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst

3 participants

@Mr-Sunglasses@picnixz@hugovk