Uh oh!
There was an error while loading. Please reload this page.
gh-111178: Fix function signatures of unicodeiter - #130684
Merged
Merged
Conversation
picnixz
reviewed
Feb 28, 2025
picnixz
left a comment
Member
There was a problem hiding this comment.
There are still UBSan failures, e.g., unicodeiter_len and unicodeiter_reduce. Could you change them as well? TiA.
vstinner
commented
Feb 28, 2025
MemberAuthor
Oh, I missed these functions. I updated them as well. Please take another look. |
picnixz
commented
Mar 4, 2025
Member
I forgot to have a look... sorry :( |
picnixz
commented
Mar 4, 2025
Member
When I forget, please don't hesistate to request a review or ping me on Discord! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.