Skip to content

gh-130149: fix HMAC tests for some FIPS-only build bots - #130788

Merged
picnixz merged 1 commit into
python:mainfrom
picnixz:tests/hmac/fix-no-builtins-130149
Mar 4, 2025
Merged

gh-130149: fix HMAC tests for some FIPS-only build bots#130788
picnixz merged 1 commit into
python:mainfrom
picnixz:tests/hmac/fix-no-builtins-130149

Conversation

@picnixz

@picnixzpicnixz commented Mar 3, 2025

Copy link
Copy Markdown
Member

I can just skip those tests on FIPS-only build bots. Currently, the Python implementation of HMAC was just delegating to any existing implementation, but some of them are not available at all (neither in OpenSSL nor as built-in modules).

So for now, Python implementation of HMAC is tested with OpenSSL hash functions instead.

@picnixz
picnixz requested a review from gpshead as a code ownerMarch 3, 2025 11:55
@bedevere-appbedevere-appBot added tests Tests in the Lib/test dir awaiting core review labels Mar 3, 2025
@bedevere-appbedevere-appBot mentioned this pull request Mar 3, 2025
@picnixz

Copy link
Copy Markdown
MemberAuthor

!buildbot FIPS

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit cc2fbe1 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130788%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixz

Copy link
Copy Markdown
MemberAuthor

I'm pretty sure the tests will fail (because those build bots are already failing) but they shouldn't fail more

@picnixz

Copy link
Copy Markdown
MemberAuthor

So, the two failures are now back to what they were previously. Those two build bots were already failing but now test_hmac does not fail anymore on them.

@picnixzpicnixz self-assigned this Mar 3, 2025
@picnixz
picnixz merged commit 15d926b into python:mainMar 4, 2025
@picnixz
picnixz deleted the tests/hmac/fix-no-builtins-130149 branch October 11, 2025 14:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@bedevere-bot