Skip to content

gh-130860: fix width calculation, when separators in fractional part - #130865

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
skirpichev:fix-width-calc/130860
Mar 6, 2025
Merged

gh-130860: fix width calculation, when separators in fractional part#130865
serhiy-storchaka merged 3 commits into
python:mainfrom
skirpichev:fix-width-calc/130860

Conversation

@skirpichev

@skirpichevskirpichev commented Mar 5, 2025

Copy link
Copy Markdown
Member

Comment threadLib/test/test_float.py Outdated

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadLib/test/test_float.py Outdated
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
serhiy-storchaka merged commit 2352bd4 into python:mainMar 6, 2025
@skirpichev
skirpichev deleted the fix-width-calc/130860 branch March 6, 2025 12:30
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Ubuntu 22.04 BigMem 3.x (tier-2) has failed when building commit 2352bd4.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1618/builds/802) and take a look at the build logs.
  4. Check if the failure is related to this commit (2352bd4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1618/builds/802

Failed tests:

  • test_interpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.diegorusso-aarch64-bigmem.bigmem/build/Lib/threading.py", line 1054, in _bootstrap_innerself.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.diegorusso-aarch64-bigmem.bigmem/build/Lib/threading.py", line 996, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.diegorusso-aarch64-bigmem.bigmem/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
interp = interpreters.create()
File "/home/buildbot/buildarea/3.x.diegorusso-aarch64-bigmem.bigmem/build/Lib/test/support/interpreters/__init__.py", line 76, in createid= _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@bedevere-bot@vstinner@serhiy-storchaka