Skip to content

gh-130664: specify how thousands separators are used with 0-padding - #131030

Open
skirpichev wants to merge 7 commits into
python:mainfrom
skirpichev:fill-docs/130664
Open

gh-130664: specify how thousands separators are used with 0-padding#131030
skirpichev wants to merge 7 commits into
python:mainfrom
skirpichev:fill-docs/130664

Conversation

@skirpichev

@skirpichevskirpichev commented Mar 10, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting review labels Mar 10, 2025
@bedevere-appbedevere-appBot mentioned this pull request Mar 10, 2025
Open
effigies
effigies reviewed Mar 10, 2025
View reviewed changes
Comment threadDoc/library/string.rst Outdated
@skirpichevskirpichev added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Apr 6, 2025
@skirpichev
skirpichev requested a review from effigiesApril 6, 2025 11:28
StanFromIreland
StanFromIreland reviewed Apr 6, 2025
View reviewed changes
Comment threadDoc/library/string.rst Outdated
@skirpichev@StanFromIreland
Update Doc/library/string.rst
71dcf25
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@skirpichevskirpichev removed the needs backport to 3.12 only security fixes label Apr 8, 2025
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@skirpichev
skirpichev requested a review from picnixzJuly 19, 2025 05:37
picnixz
picnixz reviewed Aug 2, 2025
View reviewed changes
Comment threadDoc/library/string.rst Outdated
(``'0'``) character enables sign-aware zero-padding for numeric types,
excluding :class:`complex`. This is equivalent to a *fill* character of
``'0'`` with an *alignment* type of ``'='``.
``'0'`` with an *alignment* type of ``'='``. If digit group separators of the

@picnixzpicnixzAug 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that "digit group separator" is mentioned here while we only mention it in the "grouping option" paragraph below. Maybe we should mention it at that place or mention here that this will be introduced below?

@serhiy-storchakaserhiy-storchakaAug 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the different parts of the format are interconnected, there may be references to options described in details below.

But I think that we should unify wording and avoid repetition of what specifies the grouping option. "If the grouping option for the integral part is used, a digit group separator is also inserted between leading zeros."

@skirpichevskirpichevOct 10, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka, I think that remark was addressed. Is there anything left?

@skirpichev
skirpichev requested a review from picnixzAugust 2, 2025 13:35
@skirpichev

skirpichev commented Oct 10, 2025

Copy link
Copy Markdown
MemberAuthor

CC @ericvsmith

@github-actions

github-actionsBot commented Apr 22, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 22, 2026
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 30, 2026
@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label May 31, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandAwaiting requested review from StanFromIreland
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka
@picnixzpicnixzAwaiting requested review from picnixz
1 more reviewer
@effigieseffigieseffigies approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core reviewdocsDocumentation in the Doc dirneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixesneeds backport to 3.15pre-release feature fixes, bugs and security fixesskip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skirpichev@effigies@serhiy-storchaka@picnixz@StanFromIreland@nazeerali4325-commits