Uh oh!
There was an error while loading. Please reload this page.
bpo-36778: Avoid functools in encodings.cp65001 - #13110
Conversation
There was a problem hiding this comment.
Could you please measure how much overhead it adds?
vstinner
commented
May 6, 2019
Oh, my PR looks wrong. Most CP65001Test tests fail... |
I don't know if it helps, but test_startup_imports passes on IoT Core using this change with a default codepage of cp65001. So it looks like this strategy could work if there's a way to remove functools without breaking other things. |
methane
commented
May 7, 2019
|
Replace functools.partial() with lambda to reduce the number of imports at startup. Avoid the following imports at startup: - _collections - _functools - _heapq - _operator - collections - functools - heapq - itertools - keyword - operator - reprlib
vstinner
commented
May 9, 2019
Right. I fixed my PR with that. I also rebased my PR and added a NEWS entry. |
vstinner
commented
May 9, 2019
@serhiy-storchaka: "Could you please measure how much overhead it adds?" Benchmark in release mode: |
vstinner
commented
May 10, 2019
I merged my PR #13230 instead. |
Replace functools.partial() with lambda to reduce the number of
imports at startup. Avoid the following imports at startup:
https://bugs.python.org/issue36778