Uh oh!
There was an error while loading. Please reload this page.
bpo-36766: Typos in docs and code comments - #13116
Conversation
the-knights-who-say-ni
commented
May 6, 2019
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
tirkarthi
left a comment
There was a problem hiding this comment.
LGTM. IMO, code comments are also worth fixing. I will leave it to reviewer on the same. Thank you for the contribution :)
miss-islington
commented
May 6, 2019
Thanks @penguindustin for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
commented
May 6, 2019
Sorry, @penguindustin and @matrixise, I could not cleanly backport this to |
(cherry picked from commit 9646630) Co-authored-by: penguindustin <penguindustin@gmail.com>
bedevere-bot
commented
May 6, 2019
GH-13136 is a backport of this pull request to the 3.7 branch. |
matrixise
commented
May 6, 2019
@terryjreedy keep me informed when I can close the associated PRs and the issue. Thank you so much. |
(cherry picked from commit 9646630) Co-authored-by: penguindustin <penguindustin@gmail.com> https://bugs.python.org/issue36766
matrixise
commented
May 6, 2019
@terryjreedy I have merged the backport for 3.7. |
terryjreedy
commented
May 6, 2019
A PR is permanently closed when merged. The issue can be closed when the last merge is done (easy to forget). I did it since I wanted to leave a thank you message anyway. |
* master: (1204 commits) bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (pythonGH-11521) Forbid creating of stream objects outside of asyncio (python#13101) bpo-35925: Skip SSL tests that fail due to weak external certs. (pythonGH-13124) Fix rst formatting for several links in ssl documentation (pythonGH-13133) bpo-36542: Allow to overwrite the signature for Python functions. (pythonGH-12705) bpo-36793: Remove unneeded __str__ definitions. (pythonGH-13081) bpo-36766: Typos in docs and code comments (pythonGH-13116) bpo-36275: enhance documentation for venv.create() (pythonGH-13114) Clarify the download unit in the download section (pythonGH-13122) bpo-30668: add missing word in license.rst (pythonGH-13115) Unroll import-team in CODEOWNERS (python#13118) bpo-36594: Fix incorrect use of %p in format strings (pythonGH-12769) bpo-36798: Updating f-string docs for := use case (pythonGH-13107) Update wsgiref.rst (python#10488) Doc/c-api/exceptions.rst: fix grammar (python#12091) bpo-36811: Fix a C compiler warning in _elementtree.c. (pythonGH-13109) Only count number of members once (python#12691) bpo-16024: Doc cleanup regarding path_fd, dir_fd, follow_symlinks (pythonGH-5505) bpo-36791: Safer detection of integer overflow in sum(). (pythonGH-13080) bpo-33530: Implement Happy Eyeballs in asyncio, v2 (pythonGH-7237) ...
Resolves bpo-36766
https://bugs.python.org/issue36766