Uh oh!
There was an error while loading. Please reload this page.
gh-111178: Fix function signatures in odictobject.c - #131160
Conversation
picnixz
left a comment
There was a problem hiding this comment.
If you want to also make similar changes as I did in my PRs, for the NOARGS method, I renamed the ignored parameter to dummy and for METH_O ones, I named it arg so that by reading the function itself, we can know how it's used (I found "ignored" confusing as we already have Py_UNUSED...).
If you find it bothersome or don't think it adds value, feel free to ignore this suggestion.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Mar 13, 2025
I'm fine with "ignored", so I prefer to leave these parameters as they are :-) |
Uh oh!
There was an error while loading. Please reload this page.