Skip to content

gh-130931: Add PyFrame_SetBack() function - #131252

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:frame_setback
Closed

gh-130931: Add PyFrame_SetBack() function#131252
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:frame_setback

Conversation

@vstinner

@vstinnervstinner commented Mar 14, 2025

Copy link
Copy Markdown
Member

Add tests on PyFrame_GetBack() and PyFrame_SetBack().


📚 Documentation preview 📚: https://cpython-previews--131252.org.readthedocs.build/

Add tests on PyFrame_GetBack() and PyFrame_SetBack().
@vstinner

Copy link
Copy Markdown
MemberAuthor

The coroutine support then needs to inject frames into the current stack. For this, we currently read and write f_back:
https://github.com/cython/cython/blob/f193ba860b94a7139cffd8b0d11b7ef977aa10d3/Cython/Utility/Coroutine.c#L784-L831
https://github.com/cython/cython/blob/f193ba860b94a7139cffd8b0d11b7ef977aa10d3/Cython/Utility/Coroutine.c#L870-L897

@da-woods: Would this function PyFrame_SetBack() be useful to Cython?

@vstinner

Copy link
Copy Markdown
MemberAuthor

cc @markshannon

@da-woods

Copy link
Copy Markdown
Contributor

It'd work for us for our coroutine usage, but from what Mark said, it sounds like there might be issues exposing it more generally.

@vstinner

vstinner commented Mar 20, 2025

Copy link
Copy Markdown
MemberAuthor

@markshannon is against this API: #130931 (comment). So I prefer to close my PR.

@vstinner
vstinner deleted the frame_setback branch March 20, 2025 11:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@da-woods