Uh oh!
There was an error while loading. Please reload this page.
GH-121970: Extract pydoc_topics into a new extension - #131256
Merged
Merged
Conversation
hugovk
commented
Mar 14, 2025
Member
Thanks! Do you have a good way to reproduce the original failure in a minimal way? |
AA-Turner
commented
Mar 14, 2025
MemberAuthor
$ git switch -C investigate db62557e3d1b0de4ca17786bd53f9c825ad88721
$ make -CDoc pydoc-topics
$ cp Doc/build/pydoc-topics/topics.py Lib/pydoc_data/topics.py
$ git commit -am "regenerate pydoc-topics"
$ make ci |
hugovk
approved these changes
Mar 15, 2025
AA-Turner
commented
Mar 19, 2025
MemberAuthor
Ok, let's try again... A |
hugovk
commented
Mar 20, 2025
Member
🤞 And backport? |
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @AA-Turner, I could not cleanly backport this to |
Sorry, @AA-Turner, I could not cleanly backport this to |
AA-Turner added a commit
to AA-Turner/cpython
that referenced
this pull request
Mar 20, 2025
…ythonGH-131256) (cherry picked from commit c1a02f9) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-131511 is a backport of this pull request to the 3.13 branch. |
AA-Turner added a commit
to AA-Turner/cpython
that referenced
this pull request
Mar 20, 2025
…ythonGH-131256) (cherry picked from commit c1a02f9) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-131512 is a backport of this pull request to the 3.12 branch. |
bedevere-bot
commented
Mar 20, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the error was in #130492, the attempted fix. That PR stripped all trailing whitespace, which inadvertantley also removed the final newline, leading to syntax errors, as there were four consecutive quotation marks.
This PR reapplies the reverted commit (#131245), adds a trailing newline, and finally regenerates
pydoc_data/topics.py.A
pyspecific#121970📚 Documentation preview 📚: https://cpython-previews--131256.org.readthedocs.build/