GH-131288: use _AddressOfReturnAddress in _Py_get_machine_stack_pointer to silence MSVC warning in pycore_ceval.h for release builds

[chris-eibl]

For details please see #131288.

I think this is a skip news.

• Issue: MSVC emits warnings in non-debug builds #131288

[colesbury]

Use _AddressOfReturnAddress and avoid the UB on Windows?

https://learn.microsoft.com/en-us/cpp/intrinsics/addressofreturnaddress?view=msvc-170

[chris-eibl]

Great - even better!

See https://godbolt.org/z/7c9Gq9jzM, that should work out?

[colesbury]

Yeah, it works on Windows arm64 too.

[colesbury]

GitHub actions was having some trouble, so I merged main into the PR to give it a kick

[colesbury]

!buildbot Windows

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 66f5bc5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131289%2Fmerge

The command will test the builders whose names match following regular expression: Windows

The builders matched are:

• AMD64 Windows11 Refleaks PR
• ARM64 Windows PR
• AMD64 Windows PGO NoGIL PR
• AMD64 Windows PGO PR
• ARM64 Windows Non-Debug PR
• AMD64 Windows10 PR
• AMD64 Windows11 Non-Debug PR
• AMD64 Windows11 Bigmem PR
• AMD64 Windows Server 2022 NoGIL PR

[chris-eibl]

Oh, my beloved test_int in https://buildbot.python.org/#/builders/1623/builds/13. Luckily re-run passed.

See #114911.

[colesbury]

LGTM

[colesbury]

@markshannon - would you like to review this?

[chris-eibl]

Shall we get this into the last alpha? Or before beta 1? Or no need at all?

The AMD64 Windows PGO NoGIL failure is definitely unrelated, if this is blocking ...

[colesbury]

Thanks for the reminder