Skip to content

gh-131331: rename not field to invert for C++ extension modules - #131334

Merged
brandtbucher merged 2 commits into
python:mainfrom
picnixz:fix/jit/not-in-cpp-131331
Mar 20, 2025
Merged

gh-131331: rename not field to invert for C++ extension modules#131334
brandtbucher merged 2 commits into
python:mainfrom
picnixz:fix/jit/not-in-cpp-131331

Conversation

@picnixz

@picnixzpicnixz commented Mar 16, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Mar 16, 2025
Closed
brandtbucher
brandtbucher reviewed Mar 18, 2025
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename it to invert, please?

picnixz
picnixz commented Mar 19, 2025
View reviewed changes
Comment threadInclude/internal/pycore_optimizer.h Outdated
Comment threadPython/optimizer_symbols.c Outdated
Comment threadPython/optimizer_symbols.c Outdated
Comment threadPython/optimizer_symbols.c Outdated
Comment threadPython/optimizer_symbols.c Outdated
Comment threadPython/optimizer_symbols.c Outdated
Comment threadPython/optimizer_symbols.c Outdated
Comment threadPython/optimizer_symbols.c Outdated
Comment threadPython/optimizer_symbols.c Outdated
@picnixzpicnixz changed the title gh-131331: rename not field to not_ for C++ extension modulesgh-131331: rename not field to invert for C++ extension modulesMar 19, 2025
@picnixz

picnixz commented Mar 19, 2025

Copy link
Copy Markdown
MemberAuthor

@brandtbucher Done! I'm leaving for a few days and I'll be offline. So if you want to change something, feel free to direclty edit my PR!

brandtbucher
brandtbucher approved these changes Mar 20, 2025
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brandtbucher
brandtbucher merged commit 883c2f6 into python:mainMar 20, 2025
@picnixz
picnixz deleted the fix/jit/not-in-cpp-131331 branch March 22, 2025 15:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip newstopic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@brandtbucher