Skip to content

gh-70647: Raise a more informative error for when date is out of range - #131335

Merged
gpshead merged 4 commits into
python:mainfrom
StanFromIreland:datetime-errors
Mar 21, 2025
Merged

gh-70647: Raise a more informative error for when date is out of range#131335
gpshead merged 4 commits into
python:mainfrom
StanFromIreland:datetime-errors

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Mar 16, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Finishes off #116184 (Hope Gregor doesn't mind :-)

@bedevere-appbedevere-appBot mentioned this pull request Mar 16, 2025
Closed
1 task
@StanFromIreland

StanFromIreland commented Mar 16, 2025

Copy link
Copy Markdown
MemberAuthor

Requesting @pitrou@gpshead

gpshead
gpshead requested changes Mar 16, 2025
View reviewed changes
Comment threadLib/test/datetimetester.py Outdated
@bedevere-app

bedevere-appBot commented Mar 16, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland

StanFromIreland commented Mar 16, 2025

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@bedevere-app

bedevere-appBot commented Mar 16, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-app
bedevere-appBot requested a review from gpsheadMarch 16, 2025 19:55
@StanFromIreland

StanFromIreland commented Mar 20, 2025

Copy link
Copy Markdown
MemberAuthor

@gpshead Are there any other requested changes?

@gpshead
gpshead merged commit e0fda79 into python:mainMar 21, 2025
@gpsheadgpshead mentioned this pull request Mar 21, 2025
Closed
kwilcox added a commit to closeio/ciso8601 that referenced this pull request Aug 20, 2025
@kwilcox
test new 3.14 error messages
2da03f2
python/cpython#131335
kwilcox added a commit to closeio/ciso8601 that referenced this pull request Aug 20, 2025
@kwilcox
test new 3.14 error messages
2116320
python/cpython#131335
kwilcox added a commit to closeio/ciso8601 that referenced this pull request Aug 20, 2025
@kwilcox
test new 3.14 error messages
2277d99
python/cpython#131335
@kwilcoxkwilcox mentioned this pull request Aug 20, 2025
Merged
kwilcox added a commit to closeio/ciso8601 that referenced this pull request Aug 20, 2025
@kwilcox
Test and benchmark 3.14, migrate some CI configs (#170)
663d905
* benchmark and test py314
* test new 3.14 error messages
python/cpython#131335
* test PyPy 3.11
* convert some CI to GHA
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner
@abalkinabalkinAwaiting requested review from abalkin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland@gpshead