Skip to content

GH-130415: Optimize constant comparison in JIT builds - #131489

Merged
brandtbucher merged 11 commits into
python:mainfrom
savannahostrowski:pop_2
Mar 21, 2025
Merged

GH-130415: Optimize constant comparison in JIT builds#131489
brandtbucher merged 11 commits into
python:mainfrom
savannahostrowski:pop_2

Conversation

@savannahostrowski

@savannahostrowskisavannahostrowski commented Mar 20, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Mar 20, 2025
Closed
17 tasks
@savannahostrowskisavannahostrowski changed the title GH-130415: Optimize constant comparison GH-130415: Optimize constant comparison in JIT buildsMar 20, 2025
brandtbucher
brandtbucher requested changes Mar 20, 2025
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this new instruction opens a lot of doors for us in the optimizer! A few things I noticed:

Comment threadLib/test/test_capi/test_opt.py Outdated
Comment threadPython/bytecodes.c Outdated
Comment threadPython/optimizer_bytecodes.c Outdated
@bedevere-app

bedevere-appBot commented Mar 20, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@brandtbucher

brandtbucher commented Mar 20, 2025

Copy link
Copy Markdown
Member

JIT test failure looks unrelated, and due to GH-131488.

@savannahostrowski@brandtbucher
Apply suggestions from code review
e40e580
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
brandtbucher
brandtbucher requested changes Mar 20, 2025
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more things. Also, can you merge in main? I think JIT CI should be fixed.

Comment threadLib/test/test_capi/test_opt.py Outdated
Comment threadPython/optimizer_bytecodes.c Outdated
@brandtbucher

brandtbucher commented Mar 21, 2025

Copy link
Copy Markdown
Member

Tail-calling failure is unrelated, and showing up on other PRs too.

@brandtbucher
brandtbucher merged commit b92ee14 into python:mainMar 21, 2025
@brandtbucher

brandtbucher commented Mar 21, 2025

Copy link
Copy Markdown
Member

So next steps would be doing the same thing for the other COMPARE_OP specializations (COMPARE_OP_FLOAT and COMPARE_OP_STR). Also for a bunch of BINARY_OP specializations like _BINARY_OP_ADD_INT, etc. (these are easier, since many of them already evaluate the constant... we just need to check to see if it's immortal).

Is this something you'd be interested in doing?

@brianschubertbrianschubert mentioned this pull request Mar 21, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@savannahostrowski@brandtbucher