Uh oh!
There was an error while loading. Please reload this page.
gh-130870: Preserve GenericAlias subclasses in typing.get_type_hints() - #131583
Merged
Conversation
JelleZijlstra
commented
Jun 9, 2025
Member
This generally makes sense to me, though there's a series of issues in CI. I think this can only go into 3.15 at this point. |
ZeroIntensity
commented
Jun 9, 2025
Member
Yeah, this feels like a feature to me. |
Viicos
commented
Jun 9, 2025
ContributorAuthor
I would rather consider this as a bug fix but the risk of regressions is relatively high so it also makes sense to me to include this in 3.15 only as well. |
JelleZijlstra
approved these changes
Jul 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
AndPuQing pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Pranjal095 pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
picnixz pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
taegyunkim pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #130897, that avoids recreating
GenericAliasinstances two times (no noticeable performance improvement but cleans up the implementation).It also fixes the
GenericAliasreconstruction in_strip_annotations(), and as such I moved the logic into a separate function.This approach has the benefit of not losing the
__unpacked__property of theGenericAliasif no forward annotation is present in the type hint. That is:A couple tests are failing due to this, I'm not sure how we can test this? Maybe like:
typing._eval_typeis not preservingGenericAliassubclasses #130870