Skip to content

gh-111178: Fix function signature in pyexpat.c - #131674

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:ubsan_pyexpat
Mar 24, 2025
Merged

gh-111178: Fix function signature in pyexpat.c#131674
vstinner merged 2 commits into
python:mainfrom
vstinner:ubsan_pyexpat

Conversation

@vstinner

@vstinnervstinner commented Mar 24, 2025

Copy link
Copy Markdown
Member

Move _Py_NO_SANITIZE_UNDEFINED macro from faulthandler.c to pyport.h.

Move _Py_NO_SANITIZE_UNDEFINED macro from faulthandler.c to pyport.h.
@vstinner

Copy link
Copy Markdown
MemberAuthor

cc @picnixz

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know about that macro! I was scratching my head on how to change the API without breaking everything but this solution is much cleaner. Thanks!

Comment threadModules/pyexpat.c Outdated
Comment threadModules/pyexpat.c Outdated
@vstinner
vstinner enabled auto-merge (squash) March 24, 2025 16:59
@vstinner
vstinner merged commit 5fef4ff into python:mainMar 24, 2025
@vstinner
vstinner deleted the ubsan_pyexpat branch March 24, 2025 17:22
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
Move _Py_NO_SANITIZE_UNDEFINED macro from faulthandler.c to pyport.h.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@picnixz