Skip to content

Add a single table as summary to cmath documentation - #131887

Merged
AA-Turner merged 12 commits into
python:mainfrom
skirpichev:cmath.rst-tables
Apr 6, 2025
Merged

Add a single table as summary to cmath documentation#131887
AA-Turner merged 12 commits into
python:mainfrom
skirpichev:cmath.rst-tables

Conversation

@skirpichev

@skirpichevskirpichev commented Mar 30, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--131887.org.readthedocs.build/

for reviewers:

skirpichevand others added 6 commits October 25, 2024 09:12
@skirpichev
pythongh-125957: sync argument naming in sphinx docs of the cmath and…
769c65f
… help()
@skirpichev
+ allow cmath.sin(z=1) syntax
f34de6a
In the main:
$ ./python -m timeit -r11 -s 'from cmath import sin;z=1j' 'sin(z)'
1000000 loops, best of 11: 312 nsec per loop
With patch:
$ ./python -m timeit -r11 -s 'from cmath import sin;z=1j' 'sin(z)'
1000000 loops, best of 11: 330 nsec per loop
@skirpichev
Merge branch 'master' into fix-cmath-sig-125957
680e7bf
@skirpichev
Revert second commit
57cc455
@skirpichev@picnixz
Apply suggestions from code review
ec3754e
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@skirpichev
Merge branch 'master' into fix-cmath-sig-125957
ab38770
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting review labels Mar 30, 2025
@skirpichevskirpichev added skip issue needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 30, 2025
StanFromIreland
StanFromIreland reviewed Mar 30, 2025
View reviewed changes
Comment threadDoc/library/cmath.rst Outdated
Comment threadDoc/library/cmath.rst Outdated
Comment threadDoc/library/cmath.rst
skirpichevand others added 2 commits March 30, 2025 12:37
@skirpichev@StanFromIreland
Apply suggestions from code review
eac84ff
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@skirpichev
Merge branch 'main' into cmath.rst-tables
2660f9d
AA-Turner
AA-Turner approved these changes Apr 1, 2025
View reviewed changes
Comment threadDoc/library/cmath.rst
skirpichev
skirpichev commented Apr 1, 2025
View reviewed changes
Comment threadDoc/library/cmath.rst
@python-cla-bot

python-cla-botBot commented Apr 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@hugovk@skirpichev
Remove backslash
3877f29
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
hugovk
hugovk approved these changes Apr 6, 2025
View reviewed changes
Comment threadDoc/library/cmath.rst Outdated
Comment threadDoc/library/cmath.rst Outdated
AA-Turnerand others added 2 commits April 6, 2025 21:51
@AA-Turner@hugovk
tau spacing
bc04593
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-Turner@hugovk
remove full stop
18c6098
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-Turner
AA-Turner merged commit 6eaa4ae into python:mainApr 6, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsApr 6, 2025
@miss-islington-app

miss-islington-appBot commented Apr 6, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2025
@skirpichev@AA-Turner
@picnixz@hugovk@StanFromIreland@miss-islington
Docs: Add a single table summary forcmath(pythonGH-131887)
8a6579e
(cherry picked from commit 6eaa4ae)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2025
@skirpichev@AA-Turner
@picnixz@hugovk@StanFromIreland@miss-islington
Docs: Add a single table summary forcmath(pythonGH-131887)
edbafe3
(cherry picked from commit 6eaa4ae)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Apr 6, 2025

Copy link
Copy Markdown

GH-132179 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 6, 2025
@bedevere-app

bedevere-appBot commented Apr 6, 2025

Copy link
Copy Markdown

GH-132180 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Apr 6, 2025
AA-Turner added a commit that referenced this pull request Apr 6, 2025
@miss-islington@skirpichev
@AA-Turner@picnixz@hugovk@StanFromIreland
[3.13] Docs: Add a single table summary forcmath(GH-131887) (#1…
2f1fc0f
…32179)
Docs: Add a single table summary for ``cmath`` (GH-131887)
(cherry picked from commit 6eaa4ae)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Apr 6, 2025
@miss-islington@skirpichev
@AA-Turner@picnixz@hugovk@StanFromIreland
[3.12] Docs: Add a single table summary forcmath(GH-131887) (#1…
0c429ac
…32180)
Docs: Add a single table summary for ``cmath`` (GH-131887)
(cherry picked from commit 6eaa4ae)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@skirpichev
skirpichev deleted the cmath.rst-tables branch April 7, 2025 01:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@hugovkhugovkhugovk approved these changes
@AA-TurnerAA-TurnerAA-Turner approved these changes
+1 more reviewer
@XuehaiPanXuehaiPanXuehaiPan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skirpichev@hugovk@AA-Turner@XuehaiPan@StanFromIreland