gh-130167: Add a What's New entry for changes to ``textwrap.{de,in}dent`` by AA-Turner · Pull Request #131924 · python/cpython

AA-Turner · 2025-03-31T01:19:41Z

📚 Documentation preview 📚: https://cpython-previews--131924.org.readthedocs.build/

Issue: Improve speed of stdlib functions by replacing re uses #130167

picnixz

There is a note:

Note that tabs and spaces are both treated as whitespace, but they are not
equal: the lines ``" hello"`` and ``"\thello"`` are considered to have no
common leading whitespace.

The new implementation still guarantees this right?

picnixz · 2025-03-31T08:52:58Z

+ characters other than space and tab.
+


Add something like (to be able to see the issue)
characters other than space and tab. (Contributed by [...] in :gh:`...`.)
+ 2 blank lines to end the section.

picnixz · 2025-03-31T17:13:38Z

+
+* Optimise the :func:`~textwrap.dedent` function, improving performance by
+ an average of 2.4x, with larger improvements for bigger inputs,
+ and fix a bug with incomplete normalization of blank lines with whitespace


Maybe use two separate bullet points for that? so that the reader is able to distinguish between a performance improvement and a behavioral change.

Where should the second one go? Improved Modules is mainly for features, and a standalone bullet about the bugfix in Optimisations feels wrong.

Well, I think it's still an improvement in some sense (even if we didn't treat it as a regular bugfix that we backport). For me I think that the behavioral change is important to note, hence I suggested using two separate bullet points (but still under the same section)

python-cla-bot · 2025-04-06T13:56:15Z

All commit authors signed the Contributor License Agreement.

picnixz · 2025-04-17T17:46:09Z

@AA-Turner Can you also include the typo fix of the NEWS entry (https://github.com/python/cpython/pull/131923/files#r2044429846)? TiA

hugovk · 2025-06-27T19:03:55Z

Reminder for this :)

serhiy-storchaka

LGTM. I have no opinion about normalised/normalized, please came to some conclusion.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

hugovk · 2025-12-28T14:41:22Z

@AA-Turner Can you also include the typo fix of the NEWS entry (#131923 (files))? TiA

(Was fixed in #132666)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

miss-islington-app · 2025-12-30T12:57:31Z

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…,in}dent`` (pythonGH-131924) (cherry picked from commit 7e3a5a7) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app · 2025-12-30T12:57:44Z

GH-143292 is a backport of this pull request to the 3.14 branch.

…e,in}dent`` (GH-131924) (#143292) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

…,in}dent`` (python#131924) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Note the textwrap.dedent optimisation and behaviour change
41a7ea8

AA-Turner added docs Documentation in the Doc dir skip issue skip news labels Mar 31, 2025

AA-Turner requested a review from picnixz March 31, 2025 01:19

github-project-automationBot added this to Docs PRs Mar 31, 2025

github-project-automationBot moved this to Todo in Docs PRs Mar 31, 2025

bedevere-appBot added the awaiting core review label Mar 31, 2025

AA-Turner mentioned this pull request Mar 31, 2025
gh-130167: Optimise textwrap.dedent()#131919
Merged

picnixz reviewed Mar 31, 2025
View reviewed changes

picnixz changed the title ~~Add a What's New entry for the changes to textwrap.dedent~~gh-130167: Add a What's New entry for the changes to textwrap.dedentMar 31, 2025

picnixz removed the skip issue label Mar 31, 2025

bedevere-appBot mentioned this pull request Mar 31, 2025
Improve speed of stdlib functions by replacing re uses #130167
Open

StanFromIreland reviewed Mar 31, 2025
View reviewed changes

Comment threadDoc/library/textwrap.rst Outdated

picnixz reviewed Mar 31, 2025
View reviewed changes

AA-Turner changed the title ~~gh-130167: Add a What's New entry for the changes to textwrap.dedent~~gh-130167: Add a What's New entry for the changes to textwrap.{de,in}dentApr 1, 2025

AA-Turner changed the title ~~gh-130167: Add a What's New entry for the changes to textwrap.{de,in}dent~~gh-130167: Add a What's New entry for changes to textwrap.{de,in}dentApr 1, 2025

hugovk added the needs backport to 3.14 bugs and security fixes label Jun 27, 2025

serhiy-storchaka approved these changes Dec 26, 2025
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting core review labels Dec 26, 2025

hugovk reviewed Dec 28, 2025
View reviewed changes

Comment threadDoc/whatsnew/3.14.rst Outdated

-ize
ff69b2f
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

hugovk approved these changes Dec 28, 2025
View reviewed changes

Merge branch 'main' into tw-dent-docs
2672f1a

picnixz reviewed Dec 29, 2025
View reviewed changes

Comment threadDoc/whatsnew/3.14.rst

StanFromIreland reviewed Dec 29, 2025
View reviewed changes

Comment threadDoc/whatsnew/3.14.rst

picnixz reviewed Dec 29, 2025
View reviewed changes

Comment threadDoc/library/textwrap.rst Outdated

Apply suggestions from code review
7f0f9a9
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

hugovk merged commit 7e3a5a7 into python:mainDec 30, 2025
28 checks passed

bedevere-appBot removed the awaiting merge label Dec 30, 2025

github-project-automationBot moved this from Todo to Done in Docs PRs Dec 30, 2025

bedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Dec 30, 2025

Uh oh!

Uh oh!

Conversation

AA-Turner commented Mar 31, 2025• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

picnixzMar 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

picnixzMar 31, 2025

Choose a reason for hiding this comment

Uh oh!

AA-TurnerMar 31, 2025

Choose a reason for hiding this comment

Uh oh!

picnixzMar 31, 2025

Choose a reason for hiding this comment

Uh oh!

python-cla-botBot commented Apr 6, 2025

Uh oh!

picnixz commented Apr 17, 2025

Uh oh!

hugovk commented Jun 27, 2025

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hugovk commented Dec 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-appBot commented Dec 30, 2025

Uh oh!

bedevere-appBot commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AA-Turner commented Mar 31, 2025•
edited by bedevere-app Bot
Loading

picnixzMar 31, 2025•
edited
Loading