Skip to content

gh-131938: Update error message for Element.remove() when an element is not found - #131972

Merged
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/xml/remove-error-message-131938
Apr 4, 2025
Merged

gh-131938: Update error message for Element.remove() when an element is not found#131972
picnixz merged 4 commits into
python:mainfrom
picnixz:feat/xml/remove-error-message-131938

Conversation

@picnixz

@picnixzpicnixz commented Apr 1, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Apr 1, 2025
Closed
@picnixz

picnixz commented Apr 1, 2025

Copy link
Copy Markdown
MemberAuthor

@vstinner You suggested this in the other PR, but I don't know if you want me to align the Python implementation as well. More generally, what's the policy when we have a C and a Python implementation: should the exception messages match as much as possible or is it fine to have discrepencies?

vstinner
vstinner reviewed Apr 1, 2025
View reviewed changes
Comment threadLib/test/test_xml_etree.py Outdated
Comment threadMisc/NEWS.d/next/Library/2025-04-01-13-44-26.gh-issue-131938.dm4Suq.rst
picnixz
picnixz commented Apr 1, 2025
View reviewed changes
Comment threadLib/test/test_xml_etree.py Outdated
vstinner
vstinner approved these changes Apr 1, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Apr 1, 2025
View reviewed changes
Comment threadLib/test/test_xml_etree.py Outdated
@picnixz@vstinner
Update Lib/test/test_xml_etree.py
b449607
Co-authored-by: Victor Stinner <vstinner@python.org>
@picnixz

picnixz commented Apr 1, 2025

Copy link
Copy Markdown
MemberAuthor

I'm actually leaving now so won't have time to push this, I'll do it on Friday though!

@picnixzpicnixz self-assigned this Apr 1, 2025
@picnixz
picnixz enabled auto-merge (squash) April 4, 2025 13:14
@vstinner

vstinner commented Apr 4, 2025

Copy link
Copy Markdown
Member

The Windows x64 job failed with a network issue (urllib.error.HTTPError: HTTP Error 504: Gateway Timeout). I restarted the job.

@picnixz
picnixz merged commit 04bc681 into python:mainApr 4, 2025
@picnixz
picnixz deleted the feat/xml/remove-error-message-131938 branch April 8, 2025 10:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

@picnixzpicnixz

Labels

topic-XML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@vstinner