Skip to content

Enable Windows on Arm GitHub runners - #131994

Merged
ambv merged 3 commits into
python:mainfrom
diegorusso:windows-aarch64-runners
Apr 3, 2025
Merged

Enable Windows on Arm GitHub runners#131994
ambv merged 3 commits into
python:mainfrom
diegorusso:windows-aarch64-runners

Conversation

@diegorusso

@diegorussodiegorusso commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

I had to put some if conditions in different steps because these runners are not generally available hence skipping checks on forks.

@diegorusso
diegorusso marked this pull request as draft April 1, 2025 22:13
brandtbucher
brandtbucher reviewed Apr 2, 2025
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the word "Native" from each of the JIT job names, now that we don't have the "Emulated" versions anymore?

@diegorusso

diegorusso commented Apr 2, 2025

Copy link
Copy Markdown
ContributorAuthor

The Windows on Arm runners are failing because of https://developercommunity.visualstudio.com/t/ARM64-stack-corruption-in-1443-in-OpenS/10883345

After the upgrade to OpenSSL 3.0.16 (#131839) there is a stack corruption in OpenSSL that makes crash Python on Windows on Arm.

@diegorusso
diegorusso marked this pull request as ready for review April 2, 2025 01:12
@diegorusso

diegorusso commented Apr 3, 2025

Copy link
Copy Markdown
ContributorAuthor

The Windows on Arm runners are failing because of https://developercommunity.visualstudio.com/t/ARM64-stack-corruption-in-1443-in-OpenS/10883345

After the upgrade to OpenSSL 3.0.16 (#131839) there is a stack corruption in OpenSSL that makes crash Python on Windows on Arm.

This has been fixed here: #132051

@ambv
ambv merged commit 0dbaeb9 into python:mainApr 3, 2025
@diegorusso
diegorusso deleted the windows-aarch64-runners branch April 4, 2025 13:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diegorusso@brandtbucher@ambv