Skip to content

[3.9] gh-80222: Fix email address header folding with long quoted-string (GH-122753) (GH-129111) - #132371

Merged
ambv merged 1 commit into
python:3.9from
brianschubert:backport-a4ef689-3.9
Jun 2, 2025
Merged

[3.9] gh-80222: Fix email address header folding with long quoted-string (GH-122753) (GH-129111)#132371
ambv merged 1 commit into
python:3.9from
brianschubert:backport-a4ef689-3.9

Conversation

@brianschubert

@brianschubertbrianschubert commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Email generators using email.policy.default could incorrectly omit the quote ('"') characters from a quoted-string during header refolding, leading to invalid address headers and enabling header spoofing. This change restores the quote characters on a bare-quoted-string as the header is refolded, and escapes backslash and quote chars in the string.
(cherry picked from commit 5aaf416)
(cherry picked from commit a4ef689)

…ed-string (pythonGH-122753) (pythonGH-129111)
Email generators using email.policy.default could incorrectly omit the
quote ('"') characters from a quoted-string during header refolding,
leading to invalid address headers and enabling header spoofing. This
change restores the quote characters on a bare-quoted-string as the
header is refolded, and escapes backslash and quote chars in the string.
(cherry picked from commit 5aaf416)
(cherry picked from commit a4ef689)
Co-authored-by: R. David Murray <rdmurray@bitdance.com>
Co-authored-by: Mike Edmunds <medmunds@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>

@bitdancerbitdancer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ambv
ambv merged commit d4df3c5 into python:3.9Jun 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-emailtype-securityA security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@brianschubert@bitdancer@ambv