Skip to content

gh-111178: fix incorrect function signatures in docs - #132395

Merged
picnixz merged 4 commits into
python:mainfrom
picnixz:fix/ubsan/doc-newtypes-111178
Apr 11, 2025
Merged

gh-111178: fix incorrect function signatures in docs#132395
picnixz merged 4 commits into
python:mainfrom
picnixz:fix/ubsan/doc-newtypes-111178

Conversation

@picnixz

@picnixzpicnixz commented Apr 11, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added awaiting core review docs Documentation in the Doc dir skip news labels Apr 11, 2025
@bedevere-appbedevere-appBot mentioned this pull request Apr 11, 2025
Closed
skirpichev
skirpichev reviewed Apr 11, 2025
View reviewed changes
Comment threadDoc/extending/newtypes.rst Outdated
@picnixz@skirpichev
Update Doc/extending/newtypes.rst
ace5c74
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev
skirpichev approved these changes Apr 11, 2025
View reviewed changes

@skirpichevskirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One PEP 7 nitpick.

Comment threadDoc/c-api/typeobj.rst Outdated
@picnixz@skirpichev
Update Doc/c-api/typeobj.rst
ceb30a9
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@picnixz

picnixz commented Apr 11, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for the review. Quite hard to make those fixes when there is no intellisense sometimes :')

@picnixz
picnixz enabled auto-merge (squash) April 11, 2025 14:52
picnixz
picnixz commented Apr 11, 2025
View reviewed changes
Comment threadDoc/whatsnew/3.9.rst Outdated
@picnixz
picnixz merged commit 9ded6f0 into python:mainApr 11, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsApr 11, 2025
@picnixz
picnixz deleted the fix/ubsan/doc-newtypes-111178 branch April 12, 2025 07:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichevskirpichevskirpichev approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@skirpichev