Skip to content

gh-132426: get_annotate_function vs. mapping namespaces - #132427

Closed
eliegoudout wants to merge 2 commits into
python:mainfrom
eliegoudout:132426-ns-mapping
Closed

gh-132426: get_annotate_function vs. mapping namespaces#132427
eliegoudout wants to merge 2 commits into
python:mainfrom
eliegoudout:132426-ns-mapping

Conversation

@eliegoudout

@eliegoudouteliegoudout commented Apr 12, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

@eliegoudout
fix: ns can be mapping (closespython#132426)
93afac8
Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>
@python-cla-bot

python-cla-botBot commented Apr 12, 2025•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-appBot commented Apr 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixzpicnixz changed the title fix annotationlib: namespace can be mapping (closes #132426)gh-132426: get_annotate_function should allow mapping-like objectsApr 12, 2025
@bedevere-appbedevere-appBot mentioned this pull request Apr 12, 2025
Closed
@eliegoudout

eliegoudout commented Apr 12, 2025

Copy link
Copy Markdown
Author

I convert back to draft because of this.

@eliegoudout
eliegoudout marked this pull request as draft April 12, 2025 08:58
@eliegoudouteliegoudout changed the title gh-132426: get_annotate_function should allow mapping-like objectsgh-132426: get_annotate_function vs. mapping namespacesApr 12, 2025
picnixz
picnixz reviewed Apr 12, 2025
View reviewed changes
Comment threadLib/annotationlib.py Outdated
@eliegoudout
Mapping from collections.abc, local
a4ad2c6
Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>
@bedevere-app

bedevere-appBot commented Apr 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@JelleZijlstra

JelleZijlstra commented May 4, 2025

Copy link
Copy Markdown
Member

Closing in favor of #132490

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments
@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

annotationlib: namespace can be non-dict

3 participants

@eliegoudout@JelleZijlstra@picnixz