Uh oh!
There was an error while loading. Please reload this page.
gh-132399: ensure correct alignment of PyInterpreterState when UBSan is on - #132428
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
colesbury
left a comment
There was a problem hiding this comment.
LGTM
Might be worth running the buildbots just to make sure there are no weird issues with _Alignof()
bedevere-bot
commented
Apr 18, 2025
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 12032df 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132428%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
picnixz
commented
Apr 18, 2025
Hopefully not because I don't know the alternative (it's also something that was only standardized in C11 IIRC but I hope that we won't have issues) |
picnixz
commented
Apr 19, 2025
The Fedora failures are unrelated I think as they already appeared previously. |
bedevere-bot
commented
Apr 19, 2025
|
bedevere-bot
commented
Apr 19, 2025
|
With that PR, the test suite passes for the free-threaded build with UBSan:
There is still one UB failure (fixed by #131605) but this is not specific to free-threading.
cc @colesbury
-fsanitize=undefined -fno-sanitize-recoveron free-threaded build #132399