Skip to content

gh-130662: accept leading zeros in precision/width for Decimal's formatting - #132549

Merged
vstinner merged 4 commits into
python:mainfrom
skirpichev:fix-fmt-decimal/130662
Jun 2, 2025
Merged

gh-130662: accept leading zeros in precision/width for Decimal's formatting#132549
vstinner merged 4 commits into
python:mainfrom
skirpichev:fix-fmt-decimal/130662

Conversation

@skirpichev

@skirpichevskirpichev commented Apr 15, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Apr 15, 2025
Closed
@vstinner

This comment was marked as resolved.

Sign in to view
vstinner
vstinner approved these changes Apr 15, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichevskirpichev added the 3.14 bugs and security fixes label Apr 28, 2025
@skirpichevskirpichev added needs backport to 3.14 bugs and security fixes and removed 3.14 bugs and security fixes labels May 8, 2025
picnixz

This comment was marked as resolved.

Sign in to view

@skirpichev
skirpichev requested a review from picnixzJune 2, 2025 11:38
picnixz
picnixz approved these changes Jun 2, 2025
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2025-06-02-14-36-28.gh-issue-130662.Gpr2GB.rst Outdated
@skirpichev@picnixz
Update Misc/NEWS.d/next/Library/2025-06-02-14-36-28.gh-issue-130662.G…
eb4d8b4
…pr2GB.rst
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@vstinnervstinner removed the needs backport to 3.14 bugs and security fixes label Jun 2, 2025
@vstinner
vstinner merged commit 9c72658 into python:mainJun 2, 2025
@vstinner

vstinner commented Jun 2, 2025

Copy link
Copy Markdown
Member

Merged, thank you.

I don't think that this change should be backported to stable branches.

@skirpichev
skirpichev deleted the fix-fmt-decimal/130662 branch June 2, 2025 13:57
@skirpichevskirpichev mentioned this pull request Jul 7, 2025
Closed
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
@miss-islington-app

miss-islington-appBot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
@skirpichev@picnixz@miss-islington
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
19a5631
…s formatting (pythonGH-132549)
(cherry picked from commit 9c72658)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136362 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
@miss-islington@skirpichev@picnixz
[3.14]gh-130662: Accept leading zeros in precision/width for Decimal…
f87578f
…'s formatting (GH-132549) (#136362)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@skirpichev@picnixz@Pranjal095
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
cd79e61
…s formatting (python#132549)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@skirpichev@picnixz@taegyunkim
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
f3edd38
…s formatting (python#132549)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@skirpichev@picnixz@Agent-Hellboy
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
333591c
…s formatting (python#132549)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@picnixzpicnixzpicnixz approved these changes
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@vstinner@picnixz@serhiy-storchaka