Uh oh!
There was an error while loading. Please reload this page.
gh-128384: Fix for unreliable warnings unit tests. - #132611
Merged
Merged
Conversation
When the showwarning() function is replaced, make sure to restore it after the test finishes. Add a timeout for `Barrier()` so we don't hang for a long time if something goes wrong.
This was referenced Apr 16, 2025
nascheme
marked this pull request as ready for review
April 16, 2025 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
showwarning()function is replaced, make sure to restore it after the test finishes. Add a timeout forBarrier()so we don't hang for a long time if something goes wrong.