Skip to content

gh-85204: Improve locale.setlocale example - #132683

Merged
hugovk merged 1 commit into
python:mainfrom
StanFromIreland:gh-85204
Dec 16, 2025
Merged

gh-85204: Improve locale.setlocale example#132683
hugovk merged 1 commit into
python:mainfrom
StanFromIreland:gh-85204

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Apr 18, 2025•
edited by ZeroIntensity
Loading

Copy link
Copy Markdown
Member

Should now work on more platforms. getlocale returned LC_CTYPE and not LC_ALL so switched to setlocale and since it was then pretty much a setlocale example I moved it there.

📚 Documentation preview 📚: https://cpython-previews--132683.org.readthedocs.build/en/132683/library/locale.html#locale.setlocale

@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Apr 18, 2025
@bedevere-appbedevere-appBot mentioned this pull request Apr 18, 2025
Closed
@ZeroIntensityZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 18, 2025
ZeroIntensity
ZeroIntensity approved these changes May 18, 2025
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
hugovk merged commit c24e238 into python:mainDec 16, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsDec 16, 2025
@miss-islington-app

miss-islington-appBot commented Dec 16, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@StanFromIreland@miss-islington
pythongh-85204: Improvelocale.setlocaleexample (pythonGH-132683)
7f4f28f
(cherry picked from commit c24e238)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@StanFromIreland@miss-islington
pythongh-85204: Improvelocale.setlocaleexample (pythonGH-132683)
91634e9
(cherry picked from commit c24e238)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142798 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Dec 16, 2025
@bedevere-app

bedevere-appBot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142799 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Dec 16, 2025
hugovk pushed a commit that referenced this pull request Dec 16, 2025
@miss-islington@StanFromIreland
[3.14]gh-85204: Improvelocale.setlocaleexample (GH-132683) (#142798
968d51b
)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Dec 16, 2025
@miss-islington@StanFromIreland
[3.13]gh-85204: Improvelocale.setlocaleexample (GH-132683) (#142799
4ad9844
)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland
StanFromIreland deleted the gh-85204 branch December 16, 2025 16:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@ZeroIntensity@hugovk