Skip to content

gh-46236: Add Py_UNICODE_REPLACEMENT_CHARACTER doc - #132706

Merged
vstinner merged 3 commits into
python:mainfrom
StanFromIreland:Py_UNICODE_REPLACEMENT_CHARACTER
Apr 22, 2025
Merged

gh-46236: Add Py_UNICODE_REPLACEMENT_CHARACTER doc#132706
vstinner merged 3 commits into
python:mainfrom
StanFromIreland:Py_UNICODE_REPLACEMENT_CHARACTER

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Apr 18, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Apr 18, 2025
@bedevere-appbedevere-appBot mentioned this pull request Apr 18, 2025
Closed
33 tasks
@brianschubert

brianschubert commented Apr 18, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

I notice that Py_UNICODE_REPLACEMENT_CHARACTER is under the "Internal API" section in Include/unicodeobject.h. Does that say anything about whether this should be documented?

brianschubert
brianschubert reviewed Apr 18, 2025
View reviewed changes
Comment threadDoc/c-api/unicode.rst Outdated
vstinner
vstinner reviewed Apr 22, 2025
View reviewed changes
Comment threadDoc/c-api/unicode.rst Outdated
vstinner
vstinner reviewed Apr 22, 2025
View reviewed changes
Comment threadDoc/c-api/unicode.rst Outdated
StanFromIrelandand others added 2 commits April 22, 2025 10:45
@StanFromIreland@vstinner
Apply suggestions from code review
14c66f3
Co-authored-by: Victor Stinner <vstinner@python.org>
@StanFromIreland
Move
92cb89b
vstinner
vstinner approved these changes Apr 22, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner merged commit 5ffb894 into python:mainApr 22, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsApr 22, 2025
@vstinner

vstinner commented Apr 22, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

@StanFromIreland
StanFromIreland deleted the Py_UNICODE_REPLACEMENT_CHARACTER branch April 22, 2025 12:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianschubertbrianschubertbrianschubert left review comments
@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@brianschubert@vstinner