Skip to content

gh-132684: [Enum] only call _missing_ in __contains__ for Flags - #132790

Merged
ethanfurman merged 2 commits into
python:mainfrom
ethanfurman:enum-contains
Apr 25, 2025
Merged

gh-132684: [Enum] only call _missing_ in __contains__ for Flags#132790
ethanfurman merged 2 commits into
python:mainfrom
ethanfurman:enum-contains

Conversation

@ethanfurman

@ethanfurmanethanfurman commented Apr 22, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@ethanfurmanethanfurman added type-bug An unexpected behavior, bug, or error skip news stdlib Standard Library Python modules in the Lib/ directory 3.13 bugs and security fixes 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Apr 22, 2025
@ethanfurmanethanfurman self-assigned this Apr 22, 2025
@bedevere-appbedevere-appBot mentioned this pull request Apr 22, 2025
Closed
picnixz
picnixz reviewed Apr 24, 2025
View reviewed changes
Comment threadLib/enum.py Outdated
Comment threadLib/test/test_enum.py
@ethanfurman@picnixz
simplify code
2122e59
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
picnixz reviewed Apr 24, 2025
View reviewed changes
Comment threadLib/enum.py
picnixz
picnixz reviewed Apr 24, 2025
View reviewed changes
Comment threadLib/enum.py
@ethanfurman
ethanfurman merged commit 22bc953 into python:mainApr 25, 2025
@miss-islington-app

miss-islington-appBot commented Apr 25, 2025

Copy link
Copy Markdown

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 25, 2025
@ethanfurman@picnixz@miss-islington
pythongh-132684: [Enum] only call _missing_ in __contains__ for Flags (…
d898299
…pythonGH-132790)
(cherry picked from commit 22bc953)
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Apr 25, 2025

Copy link
Copy Markdown

GH-132896 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
ethanfurman added a commit that referenced this pull request Apr 25, 2025
@miss-islington@ethanfurman@picnixz
[3.13]gh-132684: [Enum] only call _missing_ in __contains__ for Flags (
0877222
GH-132790) (GH-132896)
gh-132684: [Enum] only call _missing_ in __contains__ for Flags (GH-132790)
(cherry picked from commit 22bc953)
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@hugovkhugovk removed 3.13 bugs and security fixes 3.14 bugs and security fixes labels May 21, 2025
@ambvambv added the needs backport to 3.12 only security fixes label Jun 3, 2025
@miss-islington-app

miss-islington-appBot commented Jun 3, 2025

Copy link
Copy Markdown

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jun 3, 2025

Copy link
Copy Markdown

Sorry, @ethanfurman, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22bc953aa9be3039629dd1315f856d2522619412 3.12

@ambv

ambv commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Backporting the fix is not trivial. I get 22 failed tests after. Let's not touch 3.12 then.

@ambvambv removed the needs backport to 3.12 only security fixes label Jun 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees

@ethanfurmanethanfurman

Labels

skip newsstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ethanfurman@ambv@picnixz@hugovk