Skip to content

gh-131591: Reset RemoteDebuggerSuupport state after fork - #132793

Merged
pablogsal merged 4 commits into
python:mainfrom
Zheaoli:manjusaka/reset-fork-remote
Apr 25, 2025
Merged

gh-131591: Reset RemoteDebuggerSuupport state after fork#132793
pablogsal merged 4 commits into
python:mainfrom
Zheaoli:manjusaka/reset-fork-remote

Conversation

@Zheaoli

@ZheaoliZheaoli commented Apr 22, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

FYI I think we need to reset process _PyRemoteDebuggerSupport state after os.fork. Otherwise, the child process may inherit the pendding_call == 1 state

@Zheaoli
pythongh-131591: Reset RemoteDebuggerSuupport state after fork
a054811
Signed-off-by: Manjusaka <me@manjusaka.me>
@bedevere-appbedevere-appBot mentioned this pull request Apr 22, 2025
Closed
@Zheaoli

Zheaoli commented Apr 24, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@pablogsal PTAL when you got time

pablogsal
pablogsal reviewed Apr 24, 2025
View reviewed changes
Comment threadModules/posixmodule.c Outdated
@pablogsal

pablogsal commented Apr 24, 2025

Copy link
Copy Markdown
Member

@godlygeek WDYT?

pablogsal
pablogsal reviewed Apr 24, 2025
View reviewed changes
Comment threadMisc/NEWS.d/next/Core_and_Builtins/2025-04-22-19-00-03.gh-issue-131591.CdEqBr.rst Outdated
Zheaoliand others added 3 commits April 24, 2025 20:27
@Zheaoli@pablogsal
Update Misc/NEWS.d/next/Core_and_Builtins/2025-04-22-19-00-03.gh-issu…
4b7b1d3
…e-131591.CdEqBr.rst
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@Zheaoli@pablogsal
Update Modules/posixmodule.c
ba09801
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@Zheaoli
fix review idea
16f3f24
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Zheaoliforce-pushed the manjusaka/reset-fork-remote branch from 8288a7e to 16f3f24CompareApril 24, 2025 12:31
@Zheaoli
Zheaoli requested a review from pablogsalApril 24, 2025 15:27
@godlygeek

godlygeek commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

FYI I think we need to reset process _PyRemoteDebuggerSupport state after os.fork.

I agree, good catch!

@pablogsal
pablogsal merged commit 3a39e33 into python:mainApr 25, 2025
@pablogsal

pablogsal commented Apr 25, 2025

Copy link
Copy Markdown
Member

Thanks a lot for your contribution @Zheaoli !

@Zheaoli
Zheaoli deleted the manjusaka/reset-fork-remote branch April 25, 2025 07:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zheaoli@pablogsal@godlygeek@ketlimBueno