Skip to content

gh-132798: Schedule removal of PyUnicode_AsDecoded/Encoded functions for 3.15 - #132799

Merged
vstinner merged 5 commits into
python:mainfrom
StanFromIreland:removal-schedule
Apr 25, 2025
Merged

gh-132798: Schedule removal of PyUnicode_AsDecoded/Encoded functions for 3.15#132799
vstinner merged 5 commits into
python:mainfrom
StanFromIreland:removal-schedule

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Apr 22, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Apr 22, 2025
Closed
ZeroIntensity
ZeroIntensity reviewed Apr 22, 2025
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions are in the limited API. I'm not sure what the procedure is for removing them, but they can't just disappear from the ABI. I think the practice is to remove them from headers when the limited API isn't used. We should probably make note of that somewhere.

@vstinner

vstinner commented Apr 22, 2025

Copy link
Copy Markdown
Member

These functions are in the limited API. I'm not sure what the procedure is for removing them

Mark them as abi_only in Misc/stable_abi.toml, keep their implementation, and use PyAPI_FUNC() in the C file.

See PyUnicode_GetSize() for an existing example.

vstinner
vstinner approved these changes Apr 22, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Apr 22, 2025
View reviewed changes
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
vstinner
vstinner reviewed Apr 22, 2025
View reviewed changes
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
vstinner
vstinner reviewed Apr 22, 2025
View reviewed changes
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
@StanFromIreland

StanFromIreland commented Apr 25, 2025

Copy link
Copy Markdown
MemberAuthor

Anything else left to do @vstinner ?

vstinner
vstinner reviewed Apr 25, 2025
View reviewed changes
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
Comment threadDoc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
@StanFromIreland@vstinner
Apply suggestions from code review
0db25d0
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Apr 25, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @serhiy-storchaka@methane

@vstinner
vstinner merged commit f6fb498 into python:mainApr 25, 2025
@StanFromIreland
StanFromIreland deleted the removal-schedule branch April 25, 2025 13:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments
@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@vstinner@ZeroIntensity